Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pipeline py deps #325

Merged
merged 4 commits into from
Jul 31, 2023
Merged

feat: add pipeline py deps #325

merged 4 commits into from
Jul 31, 2023

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam linked an issue Jul 18, 2023 that may be closed by this pull request
try adding py deps for pipeline #324
Closed
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (e537064) 55.27% compared to head (c0df35d) 55.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   55.27%   55.32%   +0.04%     
==========================================
  Files          71       71              
  Lines        4617     4622       +5     
==========================================
+ Hits         2552     2557       +5     
  Misses       2065     2065
Impacted Files Coverage Δ
src/IceFloeTracker.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cpaniaguam cpaniaguam marked this pull request as ready for review July 18, 2023 03:54
@cpaniaguam cpaniaguam requested a review from tdivoll July 18, 2023 03:54
@cpaniaguam cpaniaguam self-assigned this Jul 18, 2023
@cpaniaguam cpaniaguam added the enhancement New feature or request label Jul 18, 2023
@cpaniaguam cpaniaguam marked this pull request as draft July 20, 2023 17:12
tdivoll
tdivoll approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cpaniaguam cpaniaguam marked this pull request as ready for review July 31, 2023 17:12
@cpaniaguam cpaniaguam merged commit c165a37 into main Jul 31, 2023
4 checks passed
@cpaniaguam cpaniaguam deleted the 324-try-adding-py-deps-for-pipeline-1 branch July 31, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdivoll tdivoll tdivoll approved these changes

Assignees

@cpaniaguam cpaniaguam

Labels
enhancement New feature or request
Projects
Ice Floe Coding Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try adding py deps for pipeline
2 participants
@cpaniaguam @tdivoll