Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require compile #66

Merged
merged 1 commit into from
Jan 8, 2022
Merged

fix: require compile #66

merged 1 commit into from
Jan 8, 2022

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Jan 7, 2022

define-compilation-mode is evaluated at the top level, so it should be (require 'compile). Without require, it fails to byte-compile.

define-compilation-mode is called unconditionally, so you don't have to
autoload it.
@Wilfred Wilfred merged commit cac1b52 into Wilfred:master Jan 8, 2022
@Wilfred
Copy link
Owner

Wilfred commented Jan 8, 2022

Thanks :)

@akirak akirak deleted the require-compile branch January 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants