per-command bounds checking · WildernessLabs/Meadow.Modbus@622161d

Triggered via pull request November 7, 2023 02:50

ctacke

opened #34

bug/bounds-check

Status Success

Total duration 29s

Artifacts –

main-ci.yml

on: pull_request

11 warnings

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build: src/Meadow.Modbus/Server/ModbusRtuServer.cs#L21

The field 'ModbusRtuServer.WriteCoilRequest' is assigned but its value is never used

build: src/Meadow.Modbus/Server/ModbusRtuServer.cs#L13

The field 'ModbusRtuServer.ReadCoilRequest' is assigned but its value is never used

build: src/Meadow.Modbus/Server/ModbusRtuServer.cs#L15

The field 'ModbusRtuServer.ReadDiscreteRequest' is assigned but its value is never used

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L11

Missing XML comment for publicly visible type or member 'Extensions'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L13

Missing XML comment for publicly visible type or member 'Extensions.ConvertRegistersToInt32(ushort[])'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L29

Missing XML comment for publicly visible type or member 'ModbusClientBase'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L33

Missing XML comment for publicly visible type or member 'ModbusClientBase.Disconnected'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L34

Missing XML comment for publicly visible type or member 'ModbusClientBase.Connected'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L39

Missing XML comment for publicly visible type or member 'ModbusClientBase.IsDisposed'

build: src/Meadow.Modbus/Clients/ModbusClientBase.cs#L41

Missing XML comment for publicly visible type or member 'ModbusClientBase.GenerateWriteMessage(byte, ModbusFunction, ushort, byte[])'