V1.4.0.3 #401
Closed
V1.4.0.3 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typos
… an RTOS As Meadow.OS is back to allowing a .NET thread to be of a non-Mono priority, the IST is back to running at this higer priority, fixing WildernessLabs/Meadow_Issues#311 . The thread logic is modified to exclude non-deterministic .NET operations such as external type use, heap use, or direct invocation of a user delegate. (cherry picked from commit 53e6880)
workaround for bug in GetPortNames
Core is at zero warnings!
Remove a few state machines
(cherry picked from commit 58b4dcd)
added storage info
Update MQTT settings to TLS by default
initialize GPIOs to inputs, not outputs
improve simulation device ID
Core Cleanup + minor fixes
IsConnected() was not changing its state (true/false) when disconnection with the internet occurred, nor was the WiFi disconnection event triggered, thus generating an exception.
This reverts commit f4cc720.
Fixing warnings
patridge
reviewed
Nov 11, 2023
| @@ -1436,7 +1434,7 @@ public enum Esp32ErrorCodes | |||
| /// </summary> | |||
| Overflow = 139, | |||
| /// <summary> | |||
| /// Esp32ErrorCodes - Cancelled | |||
| /// Esp32ErrorCodes - Canceled | |||
There was a problem hiding this comment.
Arguably, this comment is wrong per the enum value name. Also, I prefer double L. 🙂
| @@ -228,6 +228,7 @@ public void ConfigureOutput(IPin pin, bool initialState, OutputType initialOutpu | |||
|
|
|||
| ConfigureOutput(pin, STM32.ResistorMode.Float, STM32.GPIOSpeed.Speed_50MHz, stm32OutputType, initialState); | |||
| } | |||
| /// <inheritdoc/> | |||
There was a problem hiding this comment.
This is new to me, but there is one earlier in this file too. One is aligned with the current text white space and this one is on its own. Is there a reason to pick either option?
| @@ -9,10 +9,10 @@ namespace Meadow; | |||
| public class F7FileSystemInfo : IPlatformOS.FileSystemInfo | |||
| { | |||
| /// <inheritdoc/> | |||
| public event ExternalStorageEventHandler ExternalStorageEvent = delegate { }; | |||
| public new event ExternalStorageEventHandler ExternalStorageEvent = delegate { }; | |||
There was a problem hiding this comment.
For my own knowledge, what's the difference between the old and new here? Feel free to just point me to the commit history if it's in there. (I'm reviewing on mobile, so switching isn't trivial.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.