Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing warnings #389

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Fixing warnings #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
227eb1c
Remove duplicate event
adrianstevens Oct 30, 2023
03f8018
Minor cleanup
adrianstevens Oct 30, 2023
9bf728c
Restore ExternalStorageEventHandler and add new
adrianstevens Oct 30, 2023
1e10441
Minor cleanup
adrianstevens Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions source/implementations/f7/Meadow.F7/Devices/Esp32Coprocessor/SharedEnums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// *************************** WARNING ***************************
//

using System;

namespace Meadow.Devices.Esp32.MessagePayloads
{
/// <summary>
Expand Down Expand Up @@ -493,7 +491,7 @@ public enum CellFunction
/// CellFunction - NetworkAtCmdEvent
/// </summary>
NetworkAtCmdEvent = 4,

/// <summary>
/// CellFunction - NetworkErrorEvent
/// </summary>
NetworkErrorEvent = 2,
Expand Down
7 changes: 3 additions & 4 deletions source/implementations/f7/Meadow.F7/Devices/F7GPIOManager_interrupts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.Collections.Generic;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using static Meadow.Core.Interop;

namespace Meadow.Devices;
Expand All @@ -17,10 +16,10 @@ public partial class F7GPIOManager : IMeadowIOController
public event InterruptHandler Interrupt = delegate { };

private Thread? _ist;
private List<int> _interruptGroupsInUse = new();
private readonly List<int> _interruptGroupsInUse = new();
private bool _firstInterrupt = true;

private IPin _nullPin = new NullPin();
private readonly IPin _nullPin = new NullPin();

/// <summary>
/// Hooks up the provided pin to the underlying OS interrupt handling
Expand Down Expand Up @@ -219,7 +218,7 @@ private void InterruptServiceThreadProc(object o)
{
Interrupt?.Invoke(ipin, state);
}
catch (Exception ex)
catch
{
Thread.Sleep(5000);
}
Expand Down
6 changes: 3 additions & 3 deletions source/implementations/f7/Meadow.F7/F7FileSystemInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ namespace Meadow;
public class F7FileSystemInfo : IPlatformOS.FileSystemInfo
{
/// <inheritdoc/>
public event ExternalStorageEventHandler ExternalStorageEvent = delegate { };
public new event ExternalStorageEventHandler ExternalStorageEvent = delegate { };

private List<IExternalStorage> _externalStorage = new();
private bool _sdSupported;
private readonly List<IExternalStorage> _externalStorage = new();
private readonly bool _sdSupported;

/// <inheritdoc/>
public override IEnumerable<IExternalStorage> ExternalStorage => _externalStorage;
Expand Down
2 changes: 1 addition & 1 deletion source/implementations/f7/Meadow.F7/Interop/Interop.termios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public struct Termios
//typedef int cc_t; /* Used for terminal special characters */
//#define NCCS 9

///* The termios structure */
//* The termios structure */

//struct termios
//{
Expand Down
Loading