Merge pull request #389 from WildernessLabs/extern

Fixing warnings
WildernessLabs · Oct 30, 2023 · 9a64b60 · 9a64b60
2 parents 411301c + 1e10441
commit 9a64b60
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/source/implementations/f7/Meadow.F7/Devices/Esp32Coprocessor/SharedEnums.cs b/source/implementations/f7/Meadow.F7/Devices/Esp32Coprocessor/SharedEnums.cs
@@ -13,8 +13,6 @@
 //      *************************** WARNING ***************************
 //
 
-using System;
-
 namespace Meadow.Devices.Esp32.MessagePayloads
 {
     /// <summary>
@@ -493,7 +491,7 @@ public enum CellFunction
         /// CellFunction - NetworkAtCmdEvent
         /// </summary>
         NetworkAtCmdEvent = 4,
-
+        /// <summary>
         /// CellFunction - NetworkErrorEvent
         /// </summary>
         NetworkErrorEvent = 2,

diff --git a/source/implementations/f7/Meadow.F7/Devices/F7GPIOManager_interrupts.cs b/source/implementations/f7/Meadow.F7/Devices/F7GPIOManager_interrupts.cs
@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.Text;
 using System.Threading;
-using System.Threading.Tasks;
 using static Meadow.Core.Interop;
 
 namespace Meadow.Devices;
@@ -17,10 +16,10 @@ public partial class F7GPIOManager : IMeadowIOController
     public event InterruptHandler Interrupt = delegate { };
 
     private Thread? _ist;
-    private List<int> _interruptGroupsInUse = new();
+    private readonly List<int> _interruptGroupsInUse = new();
     private bool _firstInterrupt = true;
 
-    private IPin _nullPin = new NullPin();
+    private readonly IPin _nullPin = new NullPin();
 
     /// <summary>
     /// Hooks up the provided pin to the underlying OS interrupt handling
@@ -219,7 +218,7 @@ private void InterruptServiceThreadProc(object o)
                 {
                     Interrupt?.Invoke(ipin, state);
                 }
-                catch (Exception ex)
+                catch
                 {
                     Thread.Sleep(5000);
                 }

diff --git a/source/implementations/f7/Meadow.F7/F7FileSystemInfo.cs b/source/implementations/f7/Meadow.F7/F7FileSystemInfo.cs
@@ -9,10 +9,10 @@ namespace Meadow;
 public class F7FileSystemInfo : IPlatformOS.FileSystemInfo
 {
     /// <inheritdoc/>
-    public event ExternalStorageEventHandler ExternalStorageEvent = delegate { };
+    public new event ExternalStorageEventHandler ExternalStorageEvent = delegate { };
 
-    private List<IExternalStorage> _externalStorage = new();
-    private bool _sdSupported;
+    private readonly List<IExternalStorage> _externalStorage = new();
+    private readonly bool _sdSupported;
 
     /// <inheritdoc/>
     public override IEnumerable<IExternalStorage> ExternalStorage => _externalStorage;

diff --git a/source/implementations/f7/Meadow.F7/Interop/Interop.termios.cs b/source/implementations/f7/Meadow.F7/Interop/Interop.termios.cs
@@ -186,7 +186,7 @@ public struct Termios
             //typedef int      cc_t;      /* Used for terminal special characters */
             //#define NCCS      9
 
-            ///* The termios structure */
+            //* The termios structure */
 
             //struct termios
             //{