Add XML docs and reduce warnings. #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,6 @@ public interface IPinDefinitions : IEnumerable<IPin> | |||
| /// <summary> | |||
| /// Gets or sets the IPinController associated with the IPins | |||
| /// </summary> | |||
| IPinController Controller { get; set; } | |||
| IPinController? Controller { get; set; } | |||
There was a problem hiding this comment.
Does this impact anything in Meadow.Core?
There was a problem hiding this comment.
@adrianstevens Good question, I was refactoring for Meadow.CLI. I'll load up Meadow.Core to see what it throws. Thanks for pointing it out.
There was a problem hiding this comment.
As per Slack "Meadow.Core builds without errors or warnings, so in theory Meadow.Core has code to check Controller's nullability.
CartBlanche
requested review from
adrianstevens
and removed request for
lamebrain
ctacke
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.