Merge pull request #214 from WildernessLabs/health_reporter_stablity

update contracts to remove bool on Sends
WildernessLabs · Apr 3, 2024 · 7ca098a · 7ca098a
2 parents 80cfb54 + 08b4674
commit 7ca098a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Source/Meadow.Contracts/Cloud/IHealthReporter.cs b/Source/Meadow.Contracts/Cloud/IHealthReporter.cs
@@ -11,7 +11,7 @@ public interface IHealthReporter
     /// Starts the health reporter based on the desired interval.
     /// </summary>
     /// <param name="interval">In minutes</param>
-    void Start(int interval);
+    Task Start(int interval);
 
     /// <summary>
     /// Can be called to manually send a health report event.

diff --git a/Source/Meadow.Contracts/Cloud/IMeadowCloudService.cs b/Source/Meadow.Contracts/Cloud/IMeadowCloudService.cs
@@ -24,21 +24,21 @@ public interface IMeadowCloudService
     /// Sends a log message to the Meadow.Cloud service
     /// </summary>
     /// <param name="cloudLog">The log entry to send</param>
-    Task<bool> SendLog(CloudLog cloudLog);
+    Task SendLog(CloudLog cloudLog);
 
     /// <summary>
     /// Sends a CloudEvent to the Meadow.Cloud service
     /// </summary>
     /// <param name="cloudEvent"></param>
-    Task<bool> SendEvent(CloudEvent cloudEvent);
+    Task SendEvent(CloudEvent cloudEvent);
 
     /// <summary>
     /// Sends a CloudEvent to the Meadow.Cloud service
     /// </summary>
     /// <param name="eventId">id used for a set of events.</param>
     /// <param name="description">Description of the event.</param>
     /// <param name="measurements">Dynamic payload of measurements to be recorded.</param>
-    public Task<bool> SendEvent(int eventId, string description, Dictionary<string, object> measurements)
+    public Task SendEvent(int eventId, string description, Dictionary<string, object> measurements)
     {
         return SendEvent(new CloudEvent()
         {
@@ -54,7 +54,7 @@ public Task<bool> SendEvent(int eventId, string description, Dictionary<string,
     /// </summary>
     /// <param name="level">The log level for the log event</param>
     /// <param name="message">The message property for the log event</param>
-    Task<bool> SendLog(LogLevel level, string message)
+    Task SendLog(LogLevel level, string message)
     {
         return SendLog(level.ToString(), message);
     }
@@ -65,7 +65,7 @@ Task<bool> SendLog(LogLevel level, string message)
     /// <param name="logLevel">The log level for the log event</param>
     /// <param name="message">The message property for the log event</param>
     /// <param name="exceptionMessage">Optional exception message data</param>
-    Task<bool> SendLog(string logLevel, string message, string? exceptionMessage = null)
+    Task SendLog(string logLevel, string message, string? exceptionMessage = null)
     {
         return SendLog(new CloudLog()
         {