Skip to content

Dev #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Feb 10, 2023
Merged

Dev #47

merged 40 commits into from
Feb 10, 2023

Conversation

rocambille
Copy link
Collaborator

Changelog

[2.0.0] - 2023-02-10

Added

  • Deployment workflows using CapRover. Thanks to Anthony Gorski.
  • Compatibility with npm alternatives (yarn, pnpm...). Set config.cli in root package.json with the wanted value.

Changed

  • Allowed usage console.info in ESLint configuration (front and back).

  • Bumped dependencies versions. Thanks to Valentin Dupin.

  • Cleaned backend/src/app.js and removed public index.html file to avoid conflicts when serving react build.

  • Breaking change: removed setup script: npm install (or any other alternative) triggers a postinstall script.

  • Breaking change: removed models "autoloading": now managers should be instantiated manually in backend/src/models/index.js.

For example, given you created a FooManager.js file to be associated with a foo table,
you should add to index, after const models = {} statement:

const FooManager = require("./FooManager");

models.foo = new FooManager();
models.foo.setDatabase(pool);
  • Breaking change: renamed connection property of managers as database to be consistent with quests.

Managers methods should be fixed from:

findAll() {
  return this.connection.query(`select * from  ${this.table}`);
}

To:

findAll() {
  return this.database.query(`select * from  ${this.table}`);
}

GorskiAnthony and others added 30 commits December 2, 2022 20:19
removed setup root script for postinstall
allowed console.info in eslint config
installed cross-end in root, and made scripts compatible with windows
refactored models for manual instantiation
@rocambille rocambille merged commit 4750c1c into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants