Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Problem with the pageloader extension with laravel-mix #3

Closed
aocneanu opened this issue Dec 9, 2017 · 12 comments · Fixed by #4
Closed

Problem with the pageloader extension with laravel-mix #3

aocneanu opened this issue Dec 9, 2017 · 12 comments · Fixed by #4
Assignees

Comments

@aocneanu
Copy link

aocneanu commented Dec 9, 2017

Hi,

When I do npm run dev with the pageloader extension enabled I get the following error:

resolve-url-loader cannot operate: CSS error
  /Users/user/code/project/resources/assets/sass/app.scss:11014:3: @keyframes missing '}'
  at error (/Users/user/code/project/node_modules/css/lib/parse/index.js:62:15)

I also opened laravel-frontend-presets/bulma#5

@Wikiki
Copy link
Owner

Wikiki commented Dec 9, 2017

Hi @aocneanu,

This extension uses sass and not scss, there is no {} used in its code. I think you should see with laravel-frontend-presets project.

Regards

@deeshrestha
Copy link

@Wikiki I have tested also. Seems like keyframes mixin is causing the problem on laravel-mix (or webpack).

@keyframes missing '}'

any clue?

@aocneanu
Copy link
Author

aocneanu commented Dec 9, 2017

I encountered this without the laravel-bulma preset too.

@Wikiki Wikiki self-assigned this Dec 10, 2017
@Wikiki
Copy link
Owner

Wikiki commented Dec 10, 2017

It seems to be linked to webpack.
Sorry I have no clue about it.

@aocneanu
Copy link
Author

It's the same problem with the switch extension.

@Wikiki
Copy link
Owner

Wikiki commented Jan 12, 2018

Hi @aocneanu,

As I said before, it's related to webpack. And there is no declaration of keyframes within switch extension.

For the pageloader sass, if it really the keyframes mixin declared into the extension I'll need some help because it's passing all my sass compilation tests.

See https://www.sassmeister.com/gist/3fc4416005e2772a6ad243a7c56ec028

@aocneanu
Copy link
Author

I just wanted to let you know that switch is affected by this too.

Thanks.

@Wikiki
Copy link
Owner

Wikiki commented Jan 12, 2018

Thanks @aocneanu but based on the fact that switch does not use keyframes, are you sure it only appears when you add switch extension to a clean Bulma project ?

@Wikiki
Copy link
Owner

Wikiki commented Jan 26, 2018

Thanks to @Grummfy for the fix

@Grummfy
Copy link
Contributor

Grummfy commented Jan 26, 2018

is it possible to release a new version?

@Wikiki
Copy link
Owner

Wikiki commented Jan 27, 2018

I'll do it today.

@Wikiki
Copy link
Owner

Wikiki commented Oct 24, 2019

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants