Caddy version to 2.11.1 by Wikid82 · Pull Request #774 · Wikid82/Charon

Wikid82 · 2026-02-27T11:12:30Z

No description provided.

github-advanced-security · 2026-02-27T11:18:17Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-actions · 2026-02-27T11:18:38Z

✅ Supply Chain Verification Results

✅ PASSED

📦 SBOM Summary

Components: 1670

🔍 Vulnerability Scan

Severity	Count
🔴 Critical	0
🟠 High	0
🟡 Medium	10
🟢 Low	3
Total	13

📎 Artifacts

SBOM (CycloneDX JSON) and Grype results available in workflow artifacts

_{Generated by Supply Chain Verification workflow • View Details}

codecov · 2026-02-27T11:20:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…us handling

…n-major-updates fix(deps): update non-major-updates (feature/beta-release)

… status handling

…ry logic

…r for better diagnostics

Copilot

Pull request overview

This PR advances the Caddy 2.11.1 rollout by updating the default build/version documentation and adding verification-gate documentation, while also hardening E2E reliability (disk pressure detection, clearer SQLite “disk full” failures, and more deterministic import-session cleanup).

Changes:

Bump/align Caddy version references to 2.11.1 (Docker default + architecture docs) and shift rollout planning/docs toward digest-bound verification gates.
Improve Playwright/E2E stability: detect SQLite “database or disk is full” as an infrastructure failure, add disk-space preflight cleanup/gates in CI, and make import-session cleanup more deterministic.
Minor dependency update: axios ^1.13.5 → ^1.13.6.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`Dockerfile`	Updates default Caddy build ARG to `2.11.1`.
`ARCHITECTURE.md`	Syncs documented Caddy version + adds rollout-gate notes and digest-based scan examples.
`docs/plans/current_spec.md`	Reframes current plan toward deterministic rollout verification gates.
`VERSION.md`	Updates release process docs and adds mandatory rollout verification gates.
`docs/reports/qa_report.md`	QA report content updated (currently has a broken title line).
`tests/utils/TestDataManager.ts`	Adds SQLite-disk-full detection and fail-fast behavior for test data creation.
`tests/global-setup.ts`	Adds SQLite-disk-full detection during global setup emergency reset.
`tests/core/caddy-import/import-page-helpers.ts`	Refactors and strengthens pending import-session cleanup and adds a deterministic reload recovery.
`tests/core/caddy-import/caddy-import-gaps.spec.ts`	Adds pre-test import-session reset; enhances session banner test via mocked status response + deterministic navigation retry.
`frontend/package.json`	Bumps `axios` version.
`frontend/package-lock.json`	Locks updated `axios` (and related transitive updates).
`.github/workflows/security-pr.yml`	Updates pinned `upload-sarif` action SHA.
`.github/workflows/e2e-tests-split.yml`	Adds disk diagnostics + best-effort cleanup + a free-space threshold gate before starting E2E environments.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

Copilot · 2026-02-27T21:22:06Z

tests/utils/TestDataManager.ts

+    if (sqliteInfraFailureMessage) {
+      throw new Error(sqliteInfraFailureMessage);
+    }


sqliteInfraFailureMessage stores only the message string, and the early guard throws new Error(sqliteInfraFailureMessage), which loses the original InfrastructureSQLiteFullError name and stack context. Consider caching the actual Error instance (or at least preserving name) so follow-on failures are clearly categorized as infrastructure failures.

Copilot · 2026-02-27T21:22:06Z

docs/reports/qa_report.md

+double check our caddy version# QA Report: Nightly Workflow Fix Audit



The first line appears to have accidental text prepended to the markdown heading (double check our caddy version# QA Report...). This breaks the document title formatting and may fail markdown validation/rendering. Please restore the heading to a proper # QA Report: ... line and move any note text to its own paragraph below.

Suggested change

double check our caddy version# QA Report: Nightly Workflow Fix Audit

# QA Report: Nightly Workflow Fix Audit

double check our caddy version

Copilot · 2026-02-27T21:22:07Z

Dockerfile

 ## Try to build the requested Caddy v2.x tag (Renovate can update this ARG).
-## If the requested tag isn't available, fall back to a known-good v2.11.0-beta.2 build.
-ARG CADDY_VERSION=2.11.0-beta.2
+## If the requested tag isn't available, fall back to a known-good v2.11.1 build.
+ARG CADDY_VERSION=2.11.1


The comment says “If the requested tag isn't available, fall back …”, but ARG CADDY_VERSION=2.11.1 is a single default value and this Dockerfile section doesn’t implement a fallback mechanism by itself. To avoid misleading future edits, either adjust the comment to describe the actual behavior (default pin) or add an explicit fallback strategy where the version is resolved.

Copilot · 2026-02-27T21:22:07Z

docs/plans/current_spec.md

+Compatibility rollout for Caddy `2.11.1` is already reflected in the build
+default (`Dockerfile` currently sets `ARG CADDY_VERSION=2.11.1`).

-`Nightly Build & Package` currently has two active workflow failures that must
-be fixed together in one minimal-scope PR:
+This plan is now focused on rollout verification and regression-proofing, not
+changing the default ARG.


The PR title suggests this is primarily a Caddy version bump, but this plan section shifts focus to rollout verification gates and the PR also includes substantial E2E/test/workflow reliability changes. Consider updating the PR title/description to reflect the broader scope so reviewers don’t miss the non-version-impacting changes.

Copilot · 2026-02-27T21:22:07Z

tests/core/caddy-import/import-page-helpers.ts

+  for (let attempt = 0; attempt < 3; attempt += 1) {
+    const status = await readImportStatus(page);
+    if (!status.hasPending) {
+      return;
+    }
+
+    await issuePendingSessionCancel(page, status.sessionId);
+
+    await expect
+      .poll(async () => {
+        const next = await readImportStatus(page);
+        return next.hasPending;
+      }, {
+        timeout: 3000,
+      })
+      .toBeFalsy();
+  }


clearPendingImportSession() loops up to 3 times, but expect.poll(...).toBeFalsy() will throw on timeout, which exits the function on the first failed poll and prevents subsequent attempts. If the intent is to retry cancel/status checks, catch poll failures and continue (or remove the loop and rely on a single poll with an appropriate timeout).

Suggested change

for (let attempt = 0; attempt < 3; attempt += 1) {

const status = await readImportStatus(page);

if (!status.hasPending) {

return;

}

await issuePendingSessionCancel(page, status.sessionId);

await expect

.poll(async () => {

const next = await readImportStatus(page);

return next.hasPending;

}, {

timeout: 3000,

})

.toBeFalsy();

}

const status = await readImportStatus(page);

if (!status.hasPending) {

return;

}

await issuePendingSessionCancel(page, status.sessionId);

await expect

.poll(async () => {

const next = await readImportStatus(page);

return next.hasPending;

}, {

// Original implementation attempted up to 3 × 3000 ms polls; use a single 9000 ms window instead.

timeout: 9000,

})

.toBeFalsy();

fix: update fallback Caddy version to 2.11.1 in Dockerfile

449d316

Wikid82 self-assigned this Feb 27, 2026

Wikid82 added the critical Must have for the release, blocks other work label Feb 27, 2026

Wikid82 added this to Charon Feb 27, 2026

Wikid82 added security Security-related caddy Caddy-specific deployment Docker, installation docker labels Feb 27, 2026

github-project-automation bot moved this to Backlog in Charon Feb 27, 2026

Wikid82 moved this from Backlog to In Review in Charon Feb 27, 2026

actions-user and others added 8 commits February 27, 2026 13:41

fix: improve import session management with enhanced cleanup and stat…

1b10198

…us handling

fix: update brace-expansion package to version 5.0.4

eb55180

fix(deps): update non-major-updates

2b3b5c3

Merge pull request #775 from Wikid82/renovate/feature/beta-release-no…

6f98962

…n-major-updates fix(deps): update non-major-updates (feature/beta-release)

Merge branch 'development' into feature/beta-release

0eb0e43

fix: implement session resume feature in Caddy import tests with mock…

24a5773

… status handling

fix: enhance navigation error handling in Caddy import tests with ret…

476e65e

…ry logic

fix: enhance SQLite error handling in global setup and TestDataManage…

feaae05

…r for better diagnostics

Wikid82 marked this pull request as ready for review February 27, 2026 21:18

Copilot AI review requested due to automatic review settings February 27, 2026 21:18

Wikid82 merged commit 99ab220 into development Feb 27, 2026
39 checks passed

github-project-automation bot moved this from In Review to Done in Charon Feb 27, 2026

Copilot started reviewing on behalf of Wikid82 February 27, 2026 21:18 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Caddy version to 2.11.1 #774

Caddy version to 2.11.1 #774
Wikid82 merged 9 commits intodevelopmentfrom
feature/beta-release

Wikid82 commented Feb 27, 2026

Uh oh!

github-advanced-security bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 27, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		double check our caddy version# QA Report: Nightly Workflow Fix Audit

Uh oh!

Conversation

Wikid82 commented Feb 27, 2026

Uh oh!

github-advanced-security bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Supply Chain Verification Results

📦 SBOM Summary

🔍 Vulnerability Scan

📎 Artifacts

Uh oh!

codecov bot commented Feb 27, 2026

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 27, 2026 •

edited

Loading