Conversation
Remove overly complex verification logic that was causing all browser
jobs to fail. Browser installation should fail fast and clearly if
there are issues.
Changes:
- Remove multi-line verification scripts from all 3 browser install steps
- Simplify to single command: npx playwright install --with-deps {browser}
- Let install step show actual errors if it fails
- Let test execution show "browser not found" errors if install incomplete
Rationale:
- Previous complex verification (using grep/find) was the failure point
- Simpler approach provides clearer error messages for debugging
- Tests themselves will fail clearly if browsers aren't available
Expected outcome:
- Install steps show actual error messages if they fail
- If install succeeds, tests execute normally
- If install "succeeds" but browser is missing, test step shows clear error
Timeout remains at 45 minutes (accommodates 10-15 min install + execution)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Playwright browser installation process in the E2E test workflow by removing complex verification logic that was causing all browser jobs to fail. The change replaces multi-line bash scripts with a single, straightforward installation command for each browser (Chromium, Firefox, WebKit).
Changes:
- Simplified browser installation from 27 lines to 1 line per browser job
- Removed verification scripts that used grep/find commands to check for browser executables
- Retained fail-fast behavior where installation errors will immediately halt the workflow
- Maintained consistent 45-minute timeout for installation and test execution
Contributor
❌ E2E Test Results: FAILED (Split Browser Jobs)Some browser tests failed. Each browser runs independently. Browser Results (Sequential Execution)
Phase 1 Hotfix Active: Each browser runs in a separate job. One browser failure does not block others. 📊 View workflow run & download reports 🤖 Phase 1 Emergency Hotfix - See docs/plans/browser_alignment_triage.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove overly complex verification logic that was causing all browser jobs to fail. Browser installation should fail fast and clearly if there are issues.
Changes:
Rationale:
Expected outcome:
Timeout remains at 45 minutes (accommodates 10-15 min install + execution)