Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate "Determine image tag" step definitions from multiple GitHub Actions workflow files. Each affected workflow had the same image tag determination logic duplicated twice in sequence, and this PR eliminates the redundant first occurrence while preserving the functional implementation.
Changes:
- Removed duplicate image tag determination logic from 4 integration test workflows (WAF, Rate Limit, CrowdSec, Cerberus)
- Removed unused
image_taginput parameter from e2e-tests workflow's manual trigger configuration - Eliminated 67-104 lines of redundant bash scripting per affected workflow file
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/waf-integration.yml |
Removed duplicate "Determine image tag" step (lines 35-95), keeping the functional version with step ID determine-tag |
.github/workflows/rate-limit-integration.yml |
Removed duplicate "Determine image tag" step (lines 35-95), keeping the functional version with step ID determine-tag |
.github/workflows/crowdsec-integration.yml |
Removed duplicate "Determine image tag" step and associated artifact fallback logic (lines 35-137), keeping the functional version |
.github/workflows/cerberus-integration.yml |
Removed duplicate "Determine image tag" step (lines 35-95), keeping the functional version with step ID determine-tag |
.github/workflows/e2e-tests.yml |
Removed unused image_tag input parameter from workflow_dispatch configuration (lines 43-46) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… workflows