Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the GitHub Actions step ID used for determining the Docker image tag across CI integration workflows so downstream steps can reference the same output name.
Changes:
- Renames the “Determine image tag” step
idfromimagetodetermine-tagin multiple workflows. - Updates image pull / fallback / SHA validation steps to reference the renamed step outputs where applicable.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/waf-integration.yml | Renames the image-tag step ID and updates downstream references. |
| .github/workflows/rate-limit-integration.yml | Renames the image-tag step ID and updates downstream references. |
| .github/workflows/e2e-tests.yml | Renames the image-tag step ID. |
| .github/workflows/crowdsec-integration.yml | Renames the image-tag step ID and updates downstream references. |
| .github/workflows/cerberus-integration.yml | Renames the image-tag step ID and updates downstream references. |
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.determine-tag.outputs.tag }}" | ||
| echo "Pulling image: $IMAGE_NAME" |
There was a problem hiding this comment.
The step id determine-tag contains a hyphen but is referenced using dot notation (steps.determine-tag...). In GitHub Actions expressions, - is parsed as an operator, so this will not resolve the step outputs and can break the workflow. Rename the step id to use underscores (e.g., determine_tag) and update references, or use bracket notation when accessing the step outputs.
| command: | | ||
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.image.outputs.tag }}" | ||
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.determine-tag.outputs.tag }}" | ||
| echo "Pulling image: $IMAGE_NAME" | ||
| docker pull "$IMAGE_NAME" | ||
| docker tag "$IMAGE_NAME" charon:local |
There was a problem hiding this comment.
This workflow defines two separate steps with the same id pull_image (one earlier in the job and another later). Step ids must be unique; duplicates can make the workflow invalid or cause steps.pull_image.* to resolve unpredictably. Rename/remove the duplicate step id so each step has a unique identifier.
| # For PRs: pr-{number}-{sha}, For branches: {sanitized-branch}-{sha} | ||
| - name: Determine image tag | ||
| id: image | ||
| id: determine-tag |
There was a problem hiding this comment.
id: determine-tag is hard to reference safely with the usual dot notation in expressions because of the hyphen. The repo already uses underscore step ids that are compatible with dot notation (e.g., .github/workflows/auto-versioning.yml uses id: determine_tag). Consider renaming this to determine_tag for consistency and to avoid expression parsing issues if outputs are referenced later.
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.determine-tag.outputs.tag }}" | ||
| echo "Pulling image: $IMAGE_NAME" |
There was a problem hiding this comment.
The step id determine-tag contains a hyphen but is referenced using dot notation (steps.determine-tag...). In GitHub Actions expressions, - is parsed as an operator, so this will not resolve the step outputs and can break the workflow. Rename the step id to use underscores (e.g., determine_tag) and update references, or use bracket notation when accessing the step outputs.
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.determine-tag.outputs.tag }}" | ||
| echo "Pulling image: $IMAGE_NAME" |
There was a problem hiding this comment.
The step id determine-tag contains a hyphen but is referenced using dot notation (steps.determine-tag...). In GitHub Actions expressions, - is parsed as an operator, so this will not resolve the step outputs and can break the workflow. Rename the step id to use underscores (e.g., determine_tag) and update references, or use bracket notation when accessing the step outputs.
| IMAGE_NAME="ghcr.io/${{ github.repository_owner }}/charon:${{ steps.determine-tag.outputs.tag }}" | ||
| echo "Pulling image: $IMAGE_NAME" |
There was a problem hiding this comment.
The step id determine-tag contains a hyphen but is referenced using dot notation (steps.determine-tag...). In GitHub Actions expressions, - is parsed as an operator, so this will not resolve the step outputs and can break the workflow. Rename the step id to use underscores (e.g., determine_tag) and update references, or use bracket notation when accessing the step outputs.
No description provided.