[FIX] Fixed Messages and Added SNS Events for Closing Session after Escalation.

[Shailesh351]

Created for testing

Closes WideChat/Rocket.Chat#1278

Clone of #75
Reverts #83

[Shailesh351]

The issues found in the main PR are

• some events are being sent multiple times. In this file handlers/InitiateSalesforceSessionHandler.ts we are calling logHandoverFailure and checkAgentStatusCallbackError which internally send SNS event
• when we receive response.statusCode === 204 from the API it's handled differently in different places. At one place we are sending event CHAT_CLOSED_DUE_TO_EMPTY_MESSAGE_FROM_LIVEAGENT and at other CHAT_CLOSED_LIVEAGENT_SESSION_EXPIRED

[ear-dev]

Thanks guys.... I will test

[ear-dev]

@Shailesh351 I tested this in preprod and it looks good. If you're good to go, I will merge. Thanks!

[ear-dev]

@Shailesh351 what is this? {"close_method": "expired_session"} <- SF.app

I'm seeing a bunch of these show up during the regression tests with the testbot. I think it might be causing our close-session-method chart to not match with sessions-started. Thanks.

[Shailesh351]

@ear-dev We are sending close_method: "expired_session" when the chat is expired from the salesforce side. That is when we receive response code 403 from the salesforce

[ear-dev]

@ear-dev We are sending close_method: "expired_session" when the chat is expired from the salesforce side. That is when we receive response code 403 from the salesforce

@Shailesh351 I'm seeing both closed_method events, 'expired_session' and 'timeout' for every timeout. Maybe we should not send an event for expired_session since we are already catching the timeout?

[Shailesh351]

@Shailesh351 I'm seeing both closed_method events, 'expired_session' and 'timeout' for every timeout. Maybe we should not send an event for expired_session since we are already catching the timeout?

@ear-dev Ohh... That's the issue. I will look into it 👍

[ear-dev]

@Shailesh351 I'm seeing both closed_method events, 'expired_session' and 'timeout' for every timeout. Maybe we should not send an event for expired_session since we are already catching the timeout?

@ear-dev Ohh... That's the issue. I will look into it 👍

@Shailesh351 I created a new story to track and come up with a fix: WideChat/Rocket.Chat#1331