[CHORE] Log Salesforce API responses in the debug mode #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexanderKanakis can you review please? thanks. |
|
@csmith14 any chance you can review this PR please? thanks... |
csmith14
reviewed
Sep 27, 2022
| } | ||
|
|
||
| public async initialize(configurationExtend: IConfigurationExtend, environmentRead: IEnvironmentRead): Promise<void> { | ||
| public async initialize(configurationExtend: IConfigurationExtend, _environmentRead: IEnvironmentRead): Promise<void> { |
Collaborator
There was a problem hiding this comment.
Why have we started replacing some of these parameter names with leading underscores? I've noticed it in a few PRs and would like to know why, so I can follow whatever the new convention is.
Collaborator
There was a problem hiding this comment.
@csmith14 Underscores indicate function parameters that need to exist but are not used within the function block. We avoid TSlint issues that way.
csmith14
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WideChat/Rocket.Chat#1303