[New] Send Queue Timer upon Escalation #74
Conversation
| private async getAnalyticsQueueTime(read: IRead, assoc: RocketChatAssociationRecord) { | ||
| const { queueTimeStart } = await retrievePersistentData(read, assoc); | ||
| if (queueTimeStart === null) { | ||
| throw new Error(ErrorLogs.QUEUE_TIME_NOT_SET); |
There was a problem hiding this comment.
What happens if this error gets thrown? Will we still send the ESCALATION_SUCCESSFUL event? Basically, we do not want to kill the event if the timer fails, we just want to send an empty string.
|
@Shailesh351 can you take a look at this one when you have a chance please? thanks. |
|
|
||
| private async getAnalyticsQueueTime(read: IRead, assoc: RocketChatAssociationRecord) { | ||
| const { queueTimeStart } = await retrievePersistentData(read, assoc); | ||
| if (queueTimeStart === null) { |
There was a problem hiding this comment.
using === here only checks for null and in the case of undefined, it will send the incorrect data. How about using !queueTimeStart ?
| return ''; | ||
| } | ||
| const dt = Math.ceil((Date.now() - queueTimeStart) / 1000); | ||
| return `${dt} seconds`; |
There was a problem hiding this comment.
@AlexanderKanakis @ear-dev PR is working as expected. Just one doubt. Currently, it logs data as string <t> seconds i.e 10 seconds , 999 seconds etc.
Are we good with this or we should just pass numeric value? Just thinking from the metrics perspective
There was a problem hiding this comment.
@Shailesh351 great question.... I just asked Molly and she would like an integer and not a string. So lets just pass the number only. I assume we can pass integers in the topic message body?
There was a problem hiding this comment.
@Shailesh351 @ear-dev Fixed with new commits.
| const dt = Math.ceil((Date.now() - queueTimeStart) / 1000); | ||
| return dt; |
There was a problem hiding this comment.
| const dt = Math.ceil((Date.now() - queueTimeStart) / 1000); | |
| return dt; | |
| return Math.ceil((Date.now() - queueTimeStart) / 1000); |
3 participants
Solves: WideChat/Rocket.Chat#1286