Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit_wrappers.py bug fix #21

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Conversation

zionsteiner
Copy link
Contributor

fit_classifier() didn't return anything if svc penalty was specified and train_size // nb_classes >= 5 and train_size >= 50

Copy link
Owner

@White-Link White-Link left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for reporting this issue!

There's a corner when self.penalty is zero, in which case the method will not return anything as well. If this is fixed your pull request will be ready to be merged.

scikit_wrappers.py Outdated Show resolved Hide resolved
scikit_wrappers.py Outdated Show resolved Hide resolved
fit_classifier() didn't return anything if svc penalty was specified and train_size // nb_classes >= 5 and train_size >= 50
@zionsteiner
Copy link
Contributor Author

Should be fixed now

@White-Link White-Link merged commit d63c42b into White-Link:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants