Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cloud-init deployment #88

Merged
merged 8 commits into from
Jan 13, 2023
Merged

feat: add cloud-init deployment #88

merged 8 commits into from
Jan 13, 2023

Conversation

matinzd
Copy link
Contributor

@matinzd matinzd commented Jan 9, 2023

Add cloud-init deployment

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2023
gmale
gmale reviewed Jan 10, 2023
View reviewed changes
cloud/cloud-init.yml Outdated Show resolved Hide resolved
@matinzd matinzd requested a review from gmale January 10, 2023 13:00
@matinzd
Copy link
Contributor Author

matinzd commented Jan 10, 2023

@gmale @slawlor

@slawlor slawlor self-requested a review January 12, 2023 21:41
slawlor
slawlor suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the cloud init bits to another readme in a doc/ folder. Then just list a pointer to it in the readme. We're going to add more common deployments in the future, and I don't want the main page cluttered for the bulk of our users.

Thanks

@matinzd matinzd requested review from slawlor and gmale and removed request for gmale and slawlor January 12, 2023 21:51
@matinzd
Copy link
Contributor Author

matinzd commented Jan 12, 2023 •
edited
Loading

Done! @slawlor

slawlor
slawlor approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@slawlor slawlor merged commit a7a0017 into WhatsApp:main Jan 13, 2023
Sultan12490
Sultan12490 reviewed Nov 30, 2024
View reviewed changes
README.md
@@ -175,6 +175,7 @@ docker ps

If you would like to configure your proxy using Kubernetes, or run the Docker runtime through Kubernetes, please see our [Helm chart README](./charts/README.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sultan12490 Sultan12490 Sultan12490 left review comments

@gmale gmale gmale left review comments

@slawlor slawlor slawlor approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matinzd @gmale @slawlor @Sultan12490 @facebook-github-bot