Improve error_info() type #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`erlfmt_scan` returns `erl_anno:location()` in errors however `erlfmt_parse` mostly returns full `erlfmt_scan:anno()` maps. The errors from the parser also surface in the return value of `erlfmt:read_nodes[_string]`
facebook-github-bot
added
the
CLA Signed
gomoripeti
commented
Nov 26, 2021
| @@ -994,7 +994,7 @@ Erlang code. | |||
|
|
|||
| %% XXX. To be refined. | |||
| -type error_description() :: term(). | |||
| -type error_info() :: {erl_anno:line(), module(), error_description()}. | |||
| -type error_info() :: {erl_anno:location() | erlfmt_scan:anno(), module(), error_description()}. | |||
There was a problem hiding this comment.
ret_err/2 throws a proper erl_anno:location(), not sure if it can be returned by parse_node or if it always returns erlfmt_scan:anno()
|
Closing in favour of #325 |
|
without this fix I get dialyzer warnings when calling |
|
(hm, I intended to reopen when adding a comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlfmt_scanreturnserl_anno:location()in errors howevererlfmt_parsemostly returns fullerlfmt_scan:anno()maps. (I'm not sure if the parser should/can be changed to also returnlocation()as the code generated by yecc just takes the second element of the token tuple, without any transformation, if it is not anerl_anno:anno()https://github.com/erlang/otp/blob/maint/lib/parsetools/include/yeccpre.hrl#L147) The errors from the parser also surface in the return value oferlfmt:read_nodes[_string]I noticed this via dialyzer when calling
erlfmt_parsedirectly.