BE: only call runnable_names once for ct_diagnostics

Summary: Refactor the code to only call `common_test::runnable_names` once.

Reviewed By: robertoaloi

Differential Revision: D51465969

fbshipit-source-id: 060713c52c6f48923434512f59648f38b5c000f1

crates/ide/src/common_test.rs

@@ -70,11 +70,10 @@ pub fn unreachable_test(
     res: &mut Vec<Diagnostic>,
     sema: &Semantic,
     file_id: FileId,
-    all: FxHashSet<TestDef>,
-    groups: FxHashMap<SmolStr, GroupDef>,
+    testcases: &Option<FxHashSet<NameArity>>,
 ) {
     let exported_test_ranges = exported_test_ranges(sema, file_id);
-    if let Ok(runnable_names) = runnable_names(sema, file_id, all, groups) {
+    if let Some(runnable_names) = testcases {
         for (name, range) in exported_test_ranges {
             if !runnable_names.contains(&name) {
                 let d = Diagnostic::new(

crates/ide/src/diagnostics.rs

@@ -1221,9 +1221,9 @@ pub fn ct_diagnostics(db: &RootDatabase, file_id: FileId) -> Vec<Diagnostic> {
 
     match &*ct_info(db, file_id) {
         CommonTestInfo::Result { all, groups } => {
-            common_test::unreachable_test(&mut res, &sema, file_id, all.clone(), groups.clone());
-            // @fb-only: let testcases =
-                // @fb-only: common_test::runnable_names(&sema, file_id, all.clone(), groups.clone()).ok();
+            let testcases =
+                common_test::runnable_names(&sema, file_id, all.clone(), groups.clone()).ok();
+            common_test::unreachable_test(&mut res, &sema, file_id, &testcases);
             // @fb-only: meta_only::ct_diagnostics(&mut res, &sema, file_id, testcases);
         }
         _ => (),