Skip to content

Commit

Permalink
erlang service: remove spurious trap_exit call
Browse files Browse the repository at this point in the history
Summary:
I don't really understand why it's there - this is called in the supervisor, that should be trapping exits already. The process itself didn't do any trapping and was not prepared to handle `EXIT` messages. This seems to be some bad migration.

Created from CodeHub with https://fburl.com/edit-in-codehub

Reviewed By: alanz

Differential Revision: D60050802

fbshipit-source-id: 3b46b089e966569f6f17d7799d31cbfa5f6571ef
  • Loading branch information
michalmuskala authored and facebook-github-bot committed Jul 23, 2024
1 parent 5431929 commit 180d30d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion erlang_service/src/erlang_service_server.erl
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
%%==============================================================================
-spec start_link() -> {ok, pid()}.
start_link() ->
process_flag(trap_exit, true),
{ok, _Pid} = gen_server:start_link({local, ?SERVER}, ?MODULE, noargs, []).

-spec process(binary()) -> ok.
Expand Down

0 comments on commit 180d30d

Please sign in to comment.