Evaluate all/0 and groups/0 in one go

Summary: Instead of having two separate requests, let's have only one. Reviewed By: michalmuskala Differential Revision: D50691891 fbshipit-source-id: b5207716d270d1a010d57f95501ee1af5cb71927
WhatsApp · Oct 27, 2023 · 0c8ee9f · 0c8ee9f
1 parent 928d26a
commit 0c8ee9f
Show file tree

Hide file tree

Showing 17 changed files with 134 additions and 173 deletions.
diff --git a/crates/erlang_service/fixtures/common_test_SUITE_ct_all.expected b/crates/erlang_service/fixtures/common_test_SUITE_ct_all.expected
diff --git a/crates/erlang_service/fixtures/common_test_SUITE_ct_groups.expected b/crates/erlang_service/fixtures/common_test_SUITE_ct_groups.expected
diff --git a/crates/erlang_service/fixtures/common_test_dynamic_SUITE_ct_all.expected b/crates/erlang_service/fixtures/common_test_dynamic_SUITE_ct_all.expected
diff --git a/crates/erlang_service/fixtures/common_test_dynamic_SUITE_ct_groups.expected b/crates/erlang_service/fixtures/common_test_dynamic_SUITE_ct_groups.expected
diff --git a/crates/erlang_service/fixtures/common_test_exception_SUITE.expected b/crates/erlang_service/fixtures/common_test_exception_SUITE.expected
diff --git a/crates/erlang_service/fixtures/common_test_incomplete_SUITE.expected b/crates/erlang_service/fixtures/common_test_incomplete_SUITE.expected
diff --git a/...ng_service/fixtures/common_test_SUITE.erl → ...erlang_service/fixtures/ct_info_SUITE.erl b/...ng_service/fixtures/common_test_SUITE.erl → ...erlang_service/fixtures/ct_info_SUITE.erl
@@ -1,4 +1,4 @@
--module(common_test_SUITE).
+-module(ct_info_SUITE).
 
 -export([all/0, groups/0]).
 -export([a/1, b/1, c/1]).

diff --git a/crates/erlang_service/fixtures/ct_info_SUITE.expected b/crates/erlang_service/fixtures/ct_info_SUITE.expected
@@ -0,0 +1,5 @@
+CT_INFO_ALL
+['a',{'group','group_a'}]
+
+CT_INFO_GROUPS
+[{'group_a',['b','c']}]
diff --git a/...ce/fixtures/common_test_dynamic_SUITE.erl → ...ervice/fixtures/ct_info_dynamic_SUITE.erl b/...ce/fixtures/common_test_dynamic_SUITE.erl → ...ervice/fixtures/ct_info_dynamic_SUITE.erl
@@ -1,4 +1,4 @@
--module(common_test_dynamic_SUITE).
+-module(ct_info_dynamic_SUITE).
 
 -export([all/0, groups/0]).
 -export([a/1, b/1, c/1]).

diff --git a/crates/erlang_service/fixtures/ct_info_dynamic_SUITE.expected b/crates/erlang_service/fixtures/ct_info_dynamic_SUITE.expected
@@ -0,0 +1,5 @@
+CT_INFO_ALL
+['a',{'group','group_a'}]
+
+CT_INFO_GROUPS
+[{'group_a',['b','c']}]
diff --git a/.../fixtures/common_test_exception_SUITE.erl → ...vice/fixtures/ct_info_exception_SUITE.erl b/.../fixtures/common_test_exception_SUITE.erl → ...vice/fixtures/ct_info_exception_SUITE.erl
@@ -1,9 +1,9 @@
--module(common_test_exception_SUITE).
+-module(ct_info_exception_SUITE).
 
 -export([all/0, groups/0]).
 -export([a/1, b/1, c/1]).
 
-all() -> {not_valid}.
+all() -> throw({not_valid}).
 
 groups() -> [{group_a, [b, c]}].
 

diff --git a/crates/erlang_service/fixtures/ct_info_exception_SUITE.expected b/crates/erlang_service/fixtures/ct_info_exception_SUITE.expected
@@ -0,0 +1 @@
+Failed to fetch CT Info for "ct_info_exception_SUITE"
diff --git a/...fixtures/common_test_incomplete_SUITE.erl → ...ice/fixtures/ct_info_incomplete_SUITE.erl b/...fixtures/common_test_incomplete_SUITE.erl → ...ice/fixtures/ct_info_incomplete_SUITE.erl
@@ -1,4 +1,4 @@
--module(common_test_incomplete_SUITE).
+-module(ct_info_incomplete_SUITE).
 
 -export([all/0, groups/0]).
 -export([a/1, b/1, c/1]).

diff --git a/crates/erlang_service/fixtures/ct_info_incomplete_SUITE.expected b/crates/erlang_service/fixtures/ct_info_incomplete_SUITE.expected
@@ -0,0 +1 @@
+Failed to fetch CT Info for "ct_info_incomplete_SUITE"