-
Notifications
You must be signed in to change notification settings - Fork 8
[WIP] windows initial support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
First a quick sanity-check question:
I think this is fine. What you are seeing is the DAP server starting; it talks with the client (ie the IDE) via stdin/stdout, so it doesn't need distribution (if the ide later tells it to attach to a running node, it will start distribution, using short or long names, depending on the node it needs to attach to).
This is strange. The "initialize" request is the first thing the client sends so if there's no reply, it means like the very basic communication is failing. According to the spec
So wondering if could it be related to that? E.g. Erlang replacing \r\n in strings by \n or something? To debug this further you could perhaps enable debug logging? |
|
The problem turned out twofold. Should use |
|
I am having a problem with code:get_debug_info/1, it does not return calls. I checked the otp submodule |
|
Now only 3 tests relying on calls in debug info fail, and the ones needing |
|
Can anyone please review c0173c3? I had to twist it quite a bit to get it to work. |
|
Still cant hit a breackpoint on windows with vscode + elp + edb but at the very least it interfaces correctly and loads the project modules. |
|
@ZeeWanderer May I recommend to split this PR into multiple, smaller ones? That will make it easier to get them reviewed/merged. There's also a conflict on |
|
Sure, @robertoaloi how do you want it split? Also i think the rebar3 stuff needs more work. As you can see i have added a function to add ebin paths |
672367f to
5356952
Compare
|
@ZeeWanderer I'd say let's first get the Windows-specific bits which are not affecting the regular mechanism (e.g. the carriage return / new line changes in one PR, the escript-related ones in another one). Then we can look at the core changes ( |
I tested edb with ELP and it turned out that on windows there are string escaping shenanigans. Had to twist the code quite a bit to lessen the amount of things that forcefully get escaped in a manner unsupported by windows powershell.
for some reason on windows with rebatr3 edb wails with modules not found if project ebin is not added.
SO far i had gotten the tests to run but they fail with
i assume it's not supposed to be
nonode@nohost, doesn't show up inepmd -nameseither.Any advice?