Attempt to support older models by allowing a clear text mode #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which models is this used for? I haven't come across any that don't work with encryption. |
|
I forgot you had opened this PR and ended up cherry picking the commits from your fork manually (I also included the macOS test "fix"). This was merged on #105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is documentation that older offer a non-encrypted IP control mode. This change allows clear text operation when no keycode is required.
LGEncryptionis given a new base class,LGEncoder, into which the termination and stripping logic is separated. If no keycode is passed to theLGTVconstructor, it will create an instance ofLGEncoderinstead ofLGEncryption. A PDF from LG describing the clear text operation is included.