Add support for message decryption and a set of get commands #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesSouza
requested changes
Jun 17, 2021
| @@ -137,4 +137,14 @@ export class LGEncryption { | |||
|
|
|||
| return Buffer.concat([ivEnc, dataEnc]); | |||
| } | |||
|
|
|||
| decrypt(cipher: Buffer) { | |||
There was a problem hiding this comment.
Can you add tests for this function to test/LGEncryption.test.ts with sample payloads?
src/classes/LGTV.ts
Outdated
| return await this.sendCommand(`VOLUME_MUTE ${isMuted ? 'on' : 'off'}`); | ||
| } | ||
|
|
||
| async getMacAddress(type: 'wired' | 'wifi') { |
There was a problem hiding this comment.
Can you move those functions in the class so they are in alphabetical order?
README.md
Outdated
| @@ -175,6 +172,46 @@ Sets the volume mute state. Returns a promise. | |||
| await lgtv.setVolumeMute(false); | |||
| ``` | |||
|
|
|||
| ### `.getMacAddress(type: 'wired' | 'wifi')` | |||
There was a problem hiding this comment.
Can you move those functions in the documentation so they are in alphabetical order?
Closed
WesSouza
approved these changes
Nov 27, 2021
|
@minhtritran apologies for force pushing on your fork, but I couldn't find another way to get the tests to run. I didn't change anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for message decryption and a set of get commands.
Addresses issue #58