fix: find-replace history #2064
Open
+10
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation seems to have been broken by Imgui updates. There is also some improvement in focus handling and also a bug in replace where the last match was not being replaced has been fixed. Fixed also slowdown in large files when only one char was typed by not searching until enter has been pressed. Added key repetitions for enter and arrows to be able to handle large number of matches and fixed some formatting problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation seems to have been broken by Imgui updates.
There is also some improvement in focus handling and also a bug in replace where the last match was not being replaced has been fixed.
Fixed also slowdown in large files when only one char was typed by not searching until enter has been pressed.
Added key repetitions for enter and arrows to be able to handle large number of matches and fixed some formatting problems.