fix: find jumps to wrong location. #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After successfully finding matches and setting the cursor to them, the screen would jump to the original window location upon closing the window. The error was caused by the wrong assumption that the scroll location should be restored when window is closed. Instead, the right ammount of scrolling needs to be calculated to account for the window no longer covering part of the text editor. Unused variable was discarded. Another unrelated error is that the history of search names cannot be accessed which will be addressed at a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After successfully finding matches and setting the cursor to them, the screen would jump to the original window location upon closing the window.
The error was caused by the wrong assumption that the scroll location should be restored when window is closed. Instead, the right amount of scrolling needs to be calculated to account for the window no longer covering part of the text editor. Unused variable was discarded.
Another unrelated error is that the history of search names cannot be accessed which will be addressed at a later PR.