Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failure when PR gets merged before jobs get finished #492

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Jobs fail if PR gets merged before jobs are finished #491;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit 7a89857 into dev Aug 13, 2024
8 checks passed
@WenjieDu WenjieDu deleted the (fix)failed_job branch August 13, 2024 06:44
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10364877863

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 83.89%

Totals Coverage Status
Change from base Build 10364630589: -0.03%
Covered Lines: 10597
Relevant Lines: 12632

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants