-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 修复登录时的传参错误 #287
Merged
🐛 修复登录时的传参错误 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
审阅者指南 by Sourcery这个拉取请求修复了登录过程中的参数错误,并将版本升级到 6.0.8。 修改后的登录流程序列图sequenceDiagram
participant User as Administrator
participant Bot
participant BiliAPI
User->>Bot: Execute qrlogin command
Bot->>BiliAPI: Request QR code
BiliAPI-->>Bot: Return QR code
Bot-->>User: Display QR code
Note over User: Scan QR code
Bot->>BiliAPI: Check login status
BiliAPI-->>Bot: Return cookies
Bot->>BiliAPI: Create web account
Note right of Bot: No longer sends DedeUserID
BiliAPI-->>Bot: Account created
Bot-->>User: Login successful
显示权限变更的类图classDiagram
class LoginCommands {
+bili_check_login
+bili_login_qrcode
+bili_logout
}
class Permissions {
+ADMIN()
+SUPERUSER
}
LoginCommands --> Permissions : uses
note for LoginCommands "Commands now use ADMIN() | SUPERUSER"
文件级别变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request fixes a parameter error during login and bumps the version to 6.0.8. Sequence diagram for the modified login processsequenceDiagram
participant User as Administrator
participant Bot
participant BiliAPI
User->>Bot: Execute qrlogin command
Bot->>BiliAPI: Request QR code
BiliAPI-->>Bot: Return QR code
Bot-->>User: Display QR code
Note over User: Scan QR code
Bot->>BiliAPI: Check login status
BiliAPI-->>Bot: Return cookies
Bot->>BiliAPI: Create web account
Note right of Bot: No longer sends DedeUserID
BiliAPI-->>Bot: Account created
Bot-->>User: Login successful
Class diagram showing permission changesclassDiagram
class LoginCommands {
+bili_check_login
+bili_login_qrcode
+bili_logout
}
class Permissions {
+ADMIN()
+SUPERUSER
}
LoginCommands --> Permissions : uses
note for LoginCommands "Commands now use ADMIN() | SUPERUSER"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @djkcyl - 我已经审查了你的更改,看起来非常棒!
以下是我在审查期间关注的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @djkcyl - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
修复登录期间的参数错误并将版本升级到 6.0.8。
Bug 修复:
日常维护:
Original summary in English
Summary by Sourcery
Fix parameter error during login and bump version to 6.0.8.
Bug Fixes:
Chores: