Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 修复登录时的传参错误 #287

Merged
merged 1 commit into from
Jan 16, 2025
Merged

🐛 修复登录时的传参错误 #287

merged 1 commit into from
Jan 16, 2025

Conversation

djkcyl
Copy link
Collaborator

@djkcyl djkcyl commented Jan 16, 2025

Summary by Sourcery

修复登录期间的参数错误并将版本升级到 6.0.8。

Bug 修复:

  • 修复了登录期间传递不必要参数的问题。

日常维护:

  • 将版本升级到 6.0.8。
Original summary in English

Summary by Sourcery

Fix parameter error during login and bump version to 6.0.8.

Bug Fixes:

  • Fixed an issue where an unnecessary parameter was passed during login.

Chores:

  • Bumped version to 6.0.8.

Copy link

sourcery-ai bot commented Jan 16, 2025

审阅者指南 by Sourcery

这个拉取请求修复了登录过程中的参数错误,并将版本升级到 6.0.8。

修改后的登录流程序列图

sequenceDiagram
    participant User as Administrator
    participant Bot
    participant BiliAPI

User->>Bot: Execute qrlogin command
Bot->>BiliAPI: Request QR code
BiliAPI-->>Bot: Return QR code
Bot-->>User: Display QR code
Note over User: Scan QR code
Bot->>BiliAPI: Check login status
BiliAPI-->>Bot: Return cookies
Bot->>BiliAPI: Create web account
Note right of Bot: No longer sends DedeUserID
BiliAPI-->>Bot: Account created
Bot-->>User: Login successful
Loading

显示权限变更的类图

classDiagram
    class LoginCommands {
        +bili_check_login
        +bili_login_qrcode
        +bili_logout
    }
    class Permissions {
        +ADMIN()
        +SUPERUSER
    }
    LoginCommands --> Permissions : uses
    note for LoginCommands "Commands now use ADMIN() | SUPERUSER"
Loading

文件级别变更

变更 详情 文件
修复 account_web_creat API 调用中的参数错误。
  • 从 API 调用中移除 int(cookies["DedeUserID"]) 参数。
nonebot_plugin_bilichat/command/login.py
升级版本号。
  • 将版本从 6.0.7 更新到 6.0.8。
pyproject.toml

提示和命令

与 Sourcery 交互

  • 触发新的审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复评论要求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您还可以使用此命令指定摘要的插入位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request fixes a parameter error during login and bumps the version to 6.0.8.

Sequence diagram for the modified login process

sequenceDiagram
    participant User as Administrator
    participant Bot
    participant BiliAPI

User->>Bot: Execute qrlogin command
Bot->>BiliAPI: Request QR code
BiliAPI-->>Bot: Return QR code
Bot-->>User: Display QR code
Note over User: Scan QR code
Bot->>BiliAPI: Check login status
BiliAPI-->>Bot: Return cookies
Bot->>BiliAPI: Create web account
Note right of Bot: No longer sends DedeUserID
BiliAPI-->>Bot: Account created
Bot-->>User: Login successful
Loading

Class diagram showing permission changes

classDiagram
    class LoginCommands {
        +bili_check_login
        +bili_login_qrcode
        +bili_logout
    }
    class Permissions {
        +ADMIN()
        +SUPERUSER
    }
    LoginCommands --> Permissions : uses
    note for LoginCommands "Commands now use ADMIN() | SUPERUSER"
Loading

File-Level Changes

Change Details Files
Fixed a parameter error in the account_web_creat API call.
  • Removed the int(cookies["DedeUserID"]) parameter from the API call.
nonebot_plugin_bilichat/command/login.py
Bumped the version number.
  • Updated the version from 6.0.7 to 6.0.8.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djkcyl - 我已经审查了你的更改,看起来非常棒!

以下是我在审查期间关注的内容
  • 🟢 一般性问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @djkcyl - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@djkcyl djkcyl merged commit 8f748c5 into master Jan 16, 2025
@djkcyl djkcyl deleted the dev branch January 16, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant