Improve compatibility with multiple auth methods #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using multiple authentication methods in Django it must be possible to direct the users to a login page where they can select the needed authentication method.
tobiasge
force-pushed
the
login-redirect
branch
from
503202b to
a2335f4
Compare
Django 5.1 introduced the LoginRequiredMiddleware that automatically requires an authenticated user on all views except those marked as not requiring a login.
tobiasge
force-pushed
the
login-redirect
branch
from
a2335f4 to
e7d1362
Compare
regoawt
requested changes
Feb 28, 2025
Collaborator
regoawt
left a comment
regoawt
left a comment
There was a problem hiding this comment.
I see what you're trying to do here but I just want to assure myself that this is the best way of implementing it.
| return self.get_response(request) | ||
| elif active_auth_backend != "azure_auth.auth_backends.AzureBackend": | ||
| # User is handled by another backend | ||
| return self.get_response(request) |
Collaborator
There was a problem hiding this comment.
Shouldn't there be a check on self.request.user.is_authenticated before returning?
Contributor
Author
There was a problem hiding this comment.
I'm not sure. In our case we have a second middleware together with a second authentication backend. So each middleware is only checking the accounts that belong to it's backend. But checking self.request.user.is_authenticated here is probably equally valid.
| return func(request, *args, **kwargs) | ||
| elif active_auth_backend != "azure_auth.auth_backends.AzureBackend": | ||
| # User is handled by another backend | ||
| return func(request, *args, **kwargs) |
Collaborator
There was a problem hiding this comment.
Same as for in the middleware - shouldn't there be a check on self.request.user.is_authenticated before returning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple authentication methods in Django it must be possible to direct the users to a login page where they can select the needed authentication method.