Fix dumpObjectStore to dump objects in a consistent order #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice catch. Dumped classes should be sorted because the order of values() is not guaranteed. This makes total sense, not only for testing. You always want reproducible results. @nlgio In fa79adb habe ich den Test noch so verbessert, dass er den "diff"-Befehl nicht mehr voraussetzt (unter Windows heißt der z.B. "fc"). Vielleicht willst du das in MiddleKit 3 übernehmen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bei den Arbeiten an middlekit3 ist aufgefallen dass ein Test-Case vermutlich schon länger immer "ok" war.
Original:
https://patch-diff.githubusercontent.com/raw/nlgio/w4py3-middlekit/pull/6.diff
Die Änderung ist eigentlich nicht richtig perfekt weil nur zugunsten des Test-Case sortiert wird.