New breaking error since 1.5.0 - MessageMovedEvent not enough parameters

[devsi]

Describe the bug
On this line since 1.5.0 you added Event:

laravel-imap/src/IMAP/Message.php

Line 1004 in d56d2cc

MessageMovedEvent::dispatch($this, $message);

But the MessageMovedEvent has this signature

laravel-imap/src/IMAP/Events/MessageMovedEvent.php

Line 20 in d56d2cc

public function __construct($old_message, $new_message) {

:

You are missing the second parameter for the event. The result is that message->moveToFolder does not work and throws an error:

Too few arguments to function Webklex\IMAP\Events\MessageMovedEvent::__construct(), 1 passed in /var/www/vendor/webklex/laravel-imap/src/IMAP/Events/Event.php on line 15 and exactly 2 expected

[Webklex]

Hi @devsi ,
thanks for your report. I just tested and released a patch :)

Best regards,

[devsi]

@Webklex Thanks for the quick response. Can I confirm the following (due to confusing name of function)

moveTofolder() fetches the message as here:

laravel-imap/src/IMAP/Message.php

Lines 1003 to 1004 in d27f53c

	$message = $target_folder->getMessage($target_status->uidnext, null, $this->fetch_options, $this->fetch_body, $this->fetch_attachment, $this->fetch_flags);
	MessageMovedEvent::dispatch($this, $message);

Does this not get a singleMessage object, rather than an array? and if so, does referencing the message as $messages[0] remain broken? I haven't tested this, I just ask in theory.

laravel-imap/src/IMAP/Events/MessageMovedEvent.php

Lines 19 to 21 in d27f53c

	public function __construct($messages) {
	$this->old_message = $messages[0];
	$this->new_message = $messages[1];

[Webklex]

MessageMovedEvent::dispatch resolves to:

public static function dispatch() {
    return event(new static(func_get_args()));
}

..the two given variables get "cought" by func_get_args() which returns an array of the two given variables which then get used to initialize the original event class. In this case an array containing the old and new message :)

If you have php 7.x running you could also do the following and use the variables directly:

public static function dispatch() {
    return event(new static(...func_get_args()));
}

..however that's in this case not an option, since laravel 5.0 doesn't require php 7.x.

[devsi]

I understand. I didn't see the dispatch() function in the parent class. That makes much more sense.

Thanks for explaining!