Add tests for ESLint rules #29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6. Thanks for tagging with Hacktoberfest and having good documentation!
This PR adds tests for all the rules in the project except for
no-filter-instead-of-find
, which already had tests. It also adds a test framework and test commands for running said tests (I picked Jest but it's easy to swap to whatever runner you'd prefer).As part of writing these tests, I believe I found two bugs. I commented out the failing case and added a
FIXME
in both relevant tests:classbody-starts-with-newline
throws an error for this code which the documentation suggests should pass:no-duplicated-chains
passes this code but the documentation suggests it should throw an error:This PR also corrects a few minor mistakes in the documentation.