Skip to content

Verify host #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2018
Merged

Verify host #20

merged 3 commits into from
Jul 12, 2018

Conversation

hobinjk
Copy link
Contributor

@hobinjk hobinjk commented Jul 11, 2018

Note that tests on travis will fail no matter what due to the API change

@hobinjk hobinjk self-assigned this Jul 11, 2018
@hobinjk hobinjk requested a review from mrstegeman July 11, 2018 21:28
@ghost ghost added the review label Jul 11, 2018
mrstegeman
mrstegeman approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@mrstegeman mrstegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hobinjk hobinjk merged commit 6cc1abf into master Jul 12, 2018
@ghost ghost removed the review label Jul 12, 2018
@hobinjk hobinjk deleted the verify-host branch July 12, 2018 13:50
@mrstegeman mrstegeman mentioned this pull request Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrstegeman mrstegeman mrstegeman approved these changes

Assignees

@hobinjk hobinjk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobinjk @mrstegeman