Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thing view tests with onOffSwitch. #935

Closed
wants to merge 3 commits into from

Conversation

sogaani
Copy link
Contributor

@sogaani sogaani commented Apr 24, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #935 into master will decrease coverage by 7.41%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   73.61%   66.19%   -7.42%     
==========================================
  Files         104      122      +18     
  Lines        5078     6120    +1042     
  Branches      778      955     +177     
==========================================
+ Hits         3738     4051     +313     
- Misses       1125     1700     +575     
- Partials      215      369     +154
Impacted Files Coverage Δ
static/js/thing.js 52.32% <100%> (ø)
src/test/schema-form/test-utils.js 100% <100%> (ø) ⬆️
src/test/thing-view/test-utils.js 62.5% <62.5%> (ø)
src/test/jsdom-common.js 90.69% <96.15%> (+11.75%) ⬆️
static/js/multi-level-sensor.js 27.27% <0%> (ø)
static/js/on-off-light.js 30.76% <0%> (ø)
static/js/smart-plug.js 18.01% <0%> (ø)
static/js/label-detail.js 29.41% <0%> (ø)
static/js/thing-detail-layout.js 5.71% <0%> (ø)
static/js/multi-level-switch.js 23.07% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8685d58...8466a02. Read the comment docs.

@sogaani sogaani mentioned this pull request Apr 25, 2018
2 tasks
@sogaani
Copy link
Contributor Author

sogaani commented Apr 25, 2018

close this pullrequest, because testing on browser is better solution. #349

@sogaani sogaani closed this Apr 25, 2018
@sogaani sogaani deleted the Add-thing-view-tests branch May 16, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants