Fix Types #112
Fix Types #112
Conversation
| .replace(/^(\s+)replaceWith\(([^}]+?)\}/m, '$1/* c8 ignore start */\n$1replaceWith($2}\n$1/* c8 ignore stop */') | ||
| .replace(/^(\s+)(["'])use strict\2;/m, '$1$2use strict$2;\n\n$1const { constructor: DocumentFragment } = document.createDocumentFragment();') | ||
| .replace(/^[^(]+/, '') | ||
| .replace(/\n exports\.Hole = Hole;[\S\s]*return exports;/m, ` |
There was a problem hiding this comment.
what has this to do with this MR?
There was a problem hiding this comment.
It fixes type hints of uhtml/init. Without this, const { html, render } = init(document) will not have types (or rather be any). See https://git.envs.net/iacore/data-soup/src/commit/fc8fbb1bb35d071caf01963e53716d95cc4ddf79/server.js#L19
There was a problem hiding this comment.
OK ... then we need to do a bit more ... to start with, the exports object is not needed, we need to replace that too. I now need to maintain manually all exports in this file + it's not clear once we remove tsc what is typescript dependency doing in here at all ... this feels like a breaking change too ... thoughts?
There was a problem hiding this comment.
also this line feels particularly cumbersome render : keyed$1,
There was a problem hiding this comment.
uhm ... I think this is landing in here with better logic to let me publish more than just init.js there: #114
|
uhm ... I think this is landing in here with better logic to let me publish more than just |
2 participants
This works. Closes #111.