Fixed Browsers which support Symbol.hasInstance #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
pushed a commit
that referenced
this pull request
Jun 17, 2018
This commit addresses both PR #28 and also introduces [npm-dollar](https://github.com/WebReflection/npm-dollar) to cean up and easily improve or maintain the package.json in the future.
|
Thanks @anthony-redFox , I've pushed myself a slightly different version of your change to avoid duplication, this is because the other change I was going to push would've conflicted with this, I hope that is fine. v1.8.2 has solved that problem. There is still a Babel issue in inheriting builtins in es5 and until I have time to see if babel 7 would work there, please ignore that error and also don't extend builtins if you transpile (at least for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://webreflection.github.io/hyperHTML-Element/test/?es5 - was broken in Chrome and Firefox in 1.8 version