Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Import fails when using node >= 7.3.0 #98

Description

@steabert

Importing document-register-element in node fails with:

TypeError: Cannot assign to read only property 'prototype' of function 'class HTMLCollection {
      constructor(secret, element, query) {
        if (secret !== privates) {
          throw new T...<omitted>...
    }'
      
      at patchClass (../node_modules/document-register-element/build/document-register-element.node.js:1370:34)
      at polyfillV1 (../node_modules/document-register-element/build/document-register-element.node.js:1382:7)
      at installCustomElements (../node_modules/document-register-element/build/document-register-element.node.js:1393:48)
      at Object.<anonymous> (../node_modules/document-register-element/build/document-register-element.node.js:1433:1)

This seems to be because of: nodejs/node@524f693

They might revert it in Node: nodejs/node#10920

Anyway, I thought I would mention this, since currently import fails when using Node 7.3.0 and 7.4.0.

Activity

  1. WebReflection commented on Jan 24, 2017

    @WebReflection
    Owner

    wait ... what has this library to do with NodeJS exactly? I'm not sure I understand your heads up (thanks though)

  2. steabert commented on Feb 10, 2017

    @steabert
    Author

    Well, we use it with node, we are running tests with jest/jsdom. But yes, as you say, this isn't really your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions