Skip to content

Reproducible export * bug #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bcomnes
Copy link

@bcomnes bcomnes commented Dec 1, 2020

Demonstrates #17 as a test case.

Next is to figure out a solution. Adding estree back to the plugins list fixes it, but as noted in c6dd7e1 there might be issues with that.

Any ideas?

@WebReflection
Copy link
Owner

Thanks for the PR, but I have two questions:

  • does ucjs break too?
  • why there's no "use strict"; directive in the failing test?

@bcomnes
Copy link
Author

bcomnes commented Dec 2, 2020

does ucjs break too?

Not sure, just found out/was reminded of that package. I will test it out now.

why there's no "use strict"; directive in the failing test?

I believe it gets added by the test runner here:

ascjs/test.js

Lines 144 to 151 in 9020158

tests.forEach(code => {
console.assert(
("'use strict';\n" + code.cjs) === ascjs(code.esm),
`\n${bold('Source')}\n${code.esm}\n${bold('Expected')}\n${code.cjs}\n${bold('Received')}\n${ascjs(code.esm)}\n`
);
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants