Refactor twig component syntax #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks again for getting this rolling! The regex was working great, but it didn't give us any opportunity to give the user a good error if they make a small mistake. This is an attempt to rewrite the logic without regex. It's possible I've missed something (though tests pass). And probably a lot more edge case tests could be added & probably we should try to "mess up" Twig syntax a bunch of times to make sure we get good errors (and ideally write tests for those errors).
This also adds the concept of a "default" block:
In this case, the content that is NOT inside the
<t:block
(so the<p>
tag + the embedded<t:successAlert type="success">Inception!</t:successAlert>
) become part of a new block calleddefault
:🔥