fix(): Fix linter warnings #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-dont
force-pushed
the
lint-all-the-things
branch
from
140263b to
ed95025
Compare
donny-dont
force-pushed
the
lint-all-the-things
branch
from
ed95025 to
0dd5cfc
Compare
Update `Invoke-Linter.ps1` to use a file for settings options. Fix all the PSAvoidUsingWriteHost issues by using `Write-Information` instead. Fix PSAvoidAssignmentToAutomaticVariable in `Install-FromMsi.ps1` by renaming a variable. Fix a PSAvoidTrailingWhitespace lint in the documentation for `Install-AhemFont.ps1`. Fix a PSAvoidDefaultValueForMandatoryParameter lint in `Invoke-CmakeBuild.ps1`. Fix a PSUseDeclaredVarsMoreThanAssignments lint in `Invoke-WebFileRequest.ps1`.
donny-dont
force-pushed
the
lint-all-the-things
branch
from
0dd5cfc to
b6577df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the PSAvoidUsingWriteHost issues by using
Write-Informationinstead.Fix PSAvoidAssignmentToAutomaticVariable in
Install-FromMsi.ps1by renaming a variable.Fix a PSAvoidTrailingWhitespace lint in the documentation for
Install-AhemFont.ps1.Fix a PSAvoidDefaultValueForMandatoryParameter lint in
Invoke-CmakeBuild.ps1.Fix a PSUseDeclaredVarsMoreThanAssignments lint in
Invoke-WebFileRequest.ps1.