Skip to content

Add TodoMVC with indexedDB storage #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add TodoMVC with indexedDB storage #523

wants to merge 19 commits into from
+10,584 −1

Conversation

@lpardosixtosMs
Copy link
Contributor

@lpardosixtosMs lpardosixtosMs commented Aug 11, 2025 •
edited
Loading

Results for the hosted prototype as of 10/24/2025

label macos.arm64.local.0_0 macos.arm64.local.0_1 macos.arm64.local.0_2 macos.arm64.local.0_3
browser Google Chrome Microsoft Edge Firefox Safari
version 141.0.7390.123 141.0.3537.92 141.0.3 18.6.0.0.20621.3.11.11.3
os macos 15.7.1 arm64 macos 15.7.1 arm64 macos 15.7.1 arm64 macos 15.7.1 arm64
model MacBookPro17,1 MacBookPro17,1 MacBookPro17,1 MacBookPro17,1
cpu Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores
runs 1 1 1 1
failed runs 0 0 0 0
TodoMVC-WebComponents-IndexedDB 18.33999999994412 17.962000000011177 20.408000000000108 31.993999999999893
TodoMVC-WebComponents-DexieJS 24.38100000000559 24.141000000014902 27.236000000000285 42.01999999999996
TodoMVC-WebComponents 3.472499999916181 3.7080000000074507 4.529999999999927 4.609999999999945
Score 87.68322699356682 86.08145523013863 73.96689058754464 54.687621681337774

@netlify
Copy link

netlify bot commented Aug 11, 2025 •
edited
Loading

✅ Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit d079142
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/68fbfbfa1cbe6f00086d50ae
😎 Deploy Preview https://deploy-preview-523--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni
Copy link
Contributor

Hi, could you rebase on the latest main branch? I'd be up for a round of reviews today.

@lpardosixtosMs
Copy link
Contributor Author

Hi, could you rebase on the latest main branch? I'd be up for a round of reviews today.

On it, if you have to choose, please prioritize reviewing this workload's design doc instead of the code.

@lpardosixtosMs lpardosixtosMs force-pushed the lpardosixtos/WCIndexeddb branch from 24e93ee to 9dd77ac Compare October 8, 2025 17:27
@lpardosixtosMs lpardosixtosMs marked this pull request as ready for review October 22, 2025 23:00
@lpardosixtosMs
Copy link
Contributor Author

@camillobruni can you take a look at this. Is this how the async runner is meant to be used?

lpardosixtosMs
lpardosixtosMs commented Oct 24, 2025
View reviewed changes
experimental/javascript-wc-indexeddb/src/storage/indexedDB-manager.js
throw new Error("Database connection is not established");

// Add todo item to IndexedDB
const transaction = this.db.transaction(this.storeName, "readwrite");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a new transaction for every store? Here the 100 items are added synchronously and it would make sense to reuse the same transactions, but what does real web pages do?

@lpardosixtosMs
Copy link
Contributor Author

Updated results showed a big improvement when calling transaction.commit in the indexedDB version across all browsers. AFAIK Dexie.js uses auto-commit under the hood. So it's fine to have the vanilla indexedDB version as an alternative with explicit commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camillobruni camillobruni Awaiting requested review from camillobruni

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpardosixtosMs @camillobruni