Release/3.1 - merge 428 (add id to input)#484
Merged
flashdesignory merged 9 commits intoWebKit:mainfrom Feb 25, 2025
Merged
Conversation
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julienw
approved these changes
Feb 11, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
thanks
and also thanks for the well-defined commits, this makes it easier to review!
camillobruni
approved these changes
Feb 11, 2025
Member
|
What's the motivation for merging this fix into 3.1? |
Contributor
Author
It's a "nice to have" low risk cleanup, that doesn't change scores. |
rniwa
approved these changes
Feb 25, 2025
|
Hi, I noticed this PR merge on the main branch while syncing the ToT code. Should this PR be merged into the |
Member
|
oh yeah, looks like we merged into a wrong branch. |
Contributor
Author
🤦 - I will open a new pr to merge into the release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original pr: #428