Conversation
julienw
left a comment
There was a problem hiding this comment.
thanks, this looks good to me
I only have a few nits before landing :) see comments below
thanks for the new tests!
|
Updated a few more things
|
|
Thanks, I like the fact we call a function better (didn't want to highlight it before :-) ) BTW I wonder if there's a way to run the tests headless too. How does it work on CI, is there a X server or something? |
|
headless would mostly depend on how the browser is set up. Given that we currently only run on macOs it wont matter for the official testing (there is no real headless on macOS I think). |
SpeedometerReadyandSpeedometerDoneevents for easier testing