Rebuild workloads #375
Merged
Rebuild workloads #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
requested review from
bgrins,
rniwa,
julienw,
issackjohn and
camillobruni
issackjohn
approved these changes
Feb 15, 2024
|
Thanks @flashdesignory. @julienw, could you please review? |
julienw
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Looks reasonable.
My understanding is that:
- angular-complex gets sourcemaps, it didn't have any before.
- vue doesn't change, only the file names change. Eventually it would be good to configure the vue workload so that the file names don't change if the content doesn't change (use a hash that depends on the content)
- newssite: similarly a filename changed but the content doesn't seem to change.
So this PR could have only the angular-complex change, not the others. But I don't mind if they're included.
flashdesignory
added
the
trivial change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuild the following workload directories:
Changes are mostly changes in new hashes created for the filenames.
As far as I can tell, no actual changes to the workloads behavior have been added.
Running charts and editors didn't create any changes.
React stockcharts and perf.webkit.org has been skipped.
@kara