TodoMVC jQuery: fix clear completed button #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
requested review from
camillobruni,
rniwa,
julienw and
issackjohn
flashdesignory
commented
Jan 26, 2024
| @@ -2,6 +2,7 @@ | |||
| "name": "todomvc-jquery", | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "http-server . -p 7001 -c-1 --cors", | |||
There was a problem hiding this comment.
not a fix here, but to be consistent with other framework scripts, added it here...
There was a problem hiding this comment.
yeah that's useful :-) thanks
julienw
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Thanks for the quick turnaround!
Do you think you can wait for #360 to land before landing this one, to avoid that @issackjohn has to rebase the big patch? (even though I think there wouldn't be a conflict in this case)
Thanks - yes, this can wait 😄 |
issackjohn
approved these changes
Jan 26, 2024
rniwa
approved these changes
Jan 27, 2024
camillobruni
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched 'id' to 'class' for 'clear-completed'.
This is necessary for the css rules to apply correctly.
Fixes issue #363
@kara