Async BenchmarkRunner and removing BenchmarkState#27
Merged
camillobruni merged 5 commits intoWebKit:mainfrom Nov 23, 2022
Merged
Async BenchmarkRunner and removing BenchmarkState#27camillobruni merged 5 commits intoWebKit:mainfrom
camillobruni merged 5 commits intoWebKit:mainfrom
Conversation
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
| this._finalize(); | ||
| return Promise.resolve(); | ||
| } | ||
| this._removeFrame(); |
Member
There was a problem hiding this comment.
Why do we need to call this._removeFrame() here??
Contributor
Author
There was a problem hiding this comment.
I'm just cargo-culting here, and moved it out of the _finalize method.
But it turns that we should remove it here to get a clean view for displaying the results page (added a comment to clarify this).
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
rniwa
reviewed
Nov 23, 2022
Contributor
Author
|
thanks! I will inject an intermediate PR that will move the functions to a more chronological oder for PR #26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the continuation-based test running with an async-await loop over all suites and tests.
This also removes the necessity of the BenchmarkState class.