Stockcharts: Mock requestAnimationFrame to setTimeout so that the run…#176
Merged
bgrins merged 1 commit intoWebKit:mainfrom May 31, 2023
Merged
Conversation
Contributor
|
I haven't checked other browsers but this pretty clearly moves work into |
bgrins
approved these changes
May 23, 2023
Contributor
|
rniwa
approved these changes
May 23, 2023
Contributor
Author
I tested with your rAF-based patch. This seems to change things but isn't removing the problem completely:
So there might still be subtle racing problems that I don't fully understand, even with your patch. |
…ner can catch asynchronous work Fixes WebKit#97
84bd558 to
7a4339a
Compare
Contributor
Author
|
I rebased on top of the latest main branch and included the results in Firefox and Chrome in the PR description above. |
camillobruni
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ner can catch asynchronous work
#97
current main branch
with this patch
I'm especially interested in the SVG version of the benchmark, and looking especially at the PanTheChart steps. Indeed these steps were the most unstable in the SVG version of the benchmark.
With this change I get very stable results in Firefox, and stable results in Chrome.
What do you think @rniwa @flashdesignory @bgrins?
Firefox Before/After


Chrome Before/After

