Add raf based measurement #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
force-pushed
the
add-raf-based-measurement
branch
2 times, most recently
from
11ab3c4
to
142589c
Compare
resources/benchmark-runner.mjs
Outdated
| let syncTime; | ||
| let asyncStartTime; | ||
| let asyncTime; | ||
| const invokerClass = params.measurementMethod === 'raf' ? RAFTestInvoker : TimerTestInvoker; |
|
Modulo function-names / bind comment. Looking good! |
camillobruni
approved these changes
May 23, 2023
resources/benchmark-runner.mjs
Outdated
| let asyncStartTime; | ||
| let asyncTime; | ||
| const invokerClass = params.measurementMethod === 'raf' ? RAFTestInvoker : TimerTestInvoker; | ||
| const invoker = new invokerClass(() => { |
There was a problem hiding this comment.
As on the other PR, maybe named-methods + bind makes this more readable?
There was a problem hiding this comment.
What do you mean by that? Could you show me an example?
There was a problem hiding this comment.
Along these lines (implying moving the *time values onto the class):
const invoker = new invokerClass(this.measureSync.bind(this), this.measureAsync.bind(this), this._report.bind(this));
...
}
measureSync(...) {
...
}
measureAsync(...) {
...
}
...
Maybe easier: using named arrow functions would be an improvement:
...
const syncStart = () => {...};
const measureAsync = () => {...};
const report = () => {...};
const invoker = new invokerClass(measureSync, measureAsync, report);
There was a problem hiding this comment.
.bind() makes it harder to read ;)
But that latter case looks better to me.
| return this._recordTestResults(suite, test, syncTime, asyncTime); | ||
| }); | ||
|
|
||
| return invoker.start(); |
There was a problem hiding this comment.
Maybe await invoker.start();
smaug----
approved these changes
May 23, 2023
rniwa
force-pushed
the
add-raf-based-measurement
branch
from
142589c
to
74bbaf6
Compare
bgrins
approved these changes
May 24, 2023
This PR adds a new query string parameter requestAnimationFrame, which takes the value of either "timer" or "raf". "timer" is the existing and default measurement method. When it's "raf", we use two consecutive requestAnimationFrame first of which runs the sync step and second of which schedules a 0s timer to signify the end of async step.
rniwa
force-pushed
the
add-raf-based-measurement
branch
from
74bbaf6
to
d2750a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new query string parameter requestAnimationFrame, which takes the value of either "timer" or "raf". "timer" is the existing and default measurement method. When it's "raf", we use two consecutive requestAnimationFrame first of which runs the sync step and second of which schedules a 0s timer to signify the end of async step.